forked from hoechenberger/mne-bids-pipeline
-
Notifications
You must be signed in to change notification settings - Fork 1
Extract and synchronise ET events #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschepers
commented
Nov 24, 2025
jschepers
commented
Nov 24, 2025
Author
|
@behinger and @jshanna100, it would be great if you could have a look at my code changes and give me some feedback. |
behinger
reviewed
Nov 25, 2025
behinger
reviewed
Nov 25, 2025
behinger
reviewed
Nov 25, 2025
behinger
reviewed
Nov 25, 2025
Member
behinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good!
Co-authored-by: Benedikt Ehinger <[email protected]>
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes & implementation decisions
et_eventsfor nowbehfolder in thesync_eyelinkfunctionfind_overlapsparameter ofread_raw_eyelinktoFalseuntil we learn more about combining binocular data_raw_extrasto the EEG ones because we found out it does not work this wayETand add them to the EEG annotations (instead of only marking the synchronisation events)BAD_ACQ_SKIPand don't have to put extra (custom) effort in the pipeline to extract them (but shift that to a later preprocessing step)_raw_extrasonsetandend_timeof the eye-tracking events by recalculating the regression coefficients from the EEG+ET synchronisationBefore merging …
docs/source/changes.md)